a7cf3f5976
Weird-pass review of pink_direct.py + exec_router.py + unified spec vs industry practice. Ranked findings, each grounded (cited sources + nautilus/FIX/OMS internals): - H1 float money math (PINK) — against consensus; ALREADY fixed by rebuild's Decimal contract - H2 crash-recovery state in /tmp — durable+atomic path needed - H3 shared VST account + symbol-membership ownership — sub-account isolation is the fix - H4 clientOrderId must be unique PER ATTEMPT — gap in my contract.py (raw request_id seed) - H5 WS-primary without explicit seqnum gap detection — add forced REST resync - M1 bare except-pass swallows; M2 dead-man-stop orphan hard-gate; M3 L673 sign bug Plus a balance section: where PINK/spec are AT/ABOVE best practice (don't 'fix' these). Net: spec sound (deviations are additions); real deviations are PINK-side; float already fixed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>