From f8826f613d619339b153ada5f49ee3bd5c2ee629 Mon Sep 17 00:00:00 2001 From: Codex Date: Wed, 17 Jun 2026 12:25:38 +0200 Subject: [PATCH] VIOLET: record PASS4-done + Task 17/18 caveats in the review queue (PR docs) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PASS 4 completed on worktree agent/oa-violet4 (/mnt/vp-oa4). Recorded in the review queue the two caveats the OA agent reported — also flagged in-code as prominent banner comments + empty marker commits on that branch: - Task 17 exec_intent: explicit reference_price required (ShadowDecision has notional, no price). - Task 18 alpha_data_feed: parse/feed-port only, no live NT/Binance in unit code. For Claude's later PASS-4 review (verify the caveats + non-vacuous tests). Co-Authored-By: Claude Opus 4.8 --- prod/docs/VIOLET_TODO_CRITICAL.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/prod/docs/VIOLET_TODO_CRITICAL.md b/prod/docs/VIOLET_TODO_CRITICAL.md index 0b593aeb..da188600 100644 --- a/prod/docs/VIOLET_TODO_CRITICAL.md +++ b/prod/docs/VIOLET_TODO_CRITICAL.md @@ -57,7 +57,16 @@ The parallel agent reports these DONE; none reviewed for correctness / BLUE-comp exits / SL floor / event-restore / slippage / cadence; review when done. **PASS 4**: `VIOLET_PART_SPEC_OA_TODO_PASS4.md` (issued 2026-06-17) — vol gate / V7 exit wrapper / -economics ledger / exec-intent / alpha data feed / time exits; review when done. +economics ledger / exec-intent / alpha data feed / time exits. **DONE on worktree +`agent/oa-violet4` (/mnt/vp-oa4)** — commits 6996a6a/7c8e524/bbebe58/3920665/f328d3a/b39d8a4. +Review when done. **Caveats to verify in review (flagged in-code as prominent banners + empty +marker commits 57ca851/8624dee/2aad0aa/539ea47):** + - **Task 17 (exec_intent):** `to_exec_intent` needs an EXPLICIT `reference_price` arg — + `ShadowDecision` has notional/exposure but NO price field, so qty can't be derived from a + decision alone. Integration owner threads the live price (PASS-3 `VenueTick`) at wiring time. + - **Task 18 (alpha_data_feed):** intentionally parse/feed-port ONLY — no live NT node / Binance + connection in unit code (NT owns its loop; dummy keys; separate feed process). Live node = the + integration owner's job. Confirm tests aren't vacuous (parse-fixture, not a live connection). **PASS 5**: `VIOLET_PART_SPEC_OA_TODO_PASS5.md` (issued 2026-06-17) — MOCK-BINGX execution stack (exec contracts + QuirkProfile seams / order FSM / mock venue / fill reducer / DARK E2E gate).