hjnormey/siloqy
Public Access
1
0
Fork 0
Code Issues 7 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

PINK: E2E trace analysis — Pass 23 closure review/unfinished fixes/ops gaps (Z1-Z14)

Browse Source 
Twenty-third (final) pass: _safe_enum fix applied to rust_backend.py but NOT
real_zinc_plane.py other copy crashes (Z1 High), no health check endpoint
silent failures invisible to orchestration (Z5 High), process_intent calls
venue.submit without exception handler venue error bypasses Rust FSM (Z6 High),
snapshot mixes Rust and Python accounting capital can diverge (Z7 Medium),
BingxVenueAdapter.close executor null-to-shutdown TOCTOU race (Z8 Medium),
generated test f-string chr(34) template SyntaxError risk on old Python (Z9
Medium), launcher uses Python 3.10+ | union syntax no min version documented
(Z10 Medium), concurrent process_intent on same slot no lock no queue (Z12
Medium). 403 total flaws across 23 passes.

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This commit is contained in:
Codex
2026-06-02 19:44:15 +02:00
parent 13822d5bfa
commit ef473ba372
3 changed files with 2198 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
PINK_DITAv2_FLAW_ANALYSIS_2026-05-31.md
View File

@@ -56,7 +56,8 @@
| W | Pass 20 (Config/Math Signs/BingX Protocol) | 14 | 4 | 7 | 3 | 0 | 0 |
| X | Pass 21 (Rust Build/Deps/Python Packaging/Shared Mem) | 14 | 3 | 5 | 6 | 0 | 0 |
| Y | Pass 22 (Serde Round-Trip/Mock Fidelity/Protocol) | 14 | 1 | 4 | 5 | 4 | 0 |
| **Total** | | **389** | **43** | **117** | **114** | **64** | **37** |
| Z | Pass 23 (Closure Review/Unfinished Fixes/Ops Gaps) | 14 | 0 | 3 | 6 | 5 | 0 |
| **Total** | | **403** | **43** | **120** | **120** | **64** | **37** |
---
@@ -626,6 +627,29 @@
---
## Z-Series: Closure Review — Unfinished Fixes, Operational Gaps, Final Edge Cases (Pass 23)
*Full detail in TRACE doc under "PASS 23 — CLOSURE/REVIEW: UNFINISHED FIXES, OPERATIONAL GAPS, FINAL EDGE CASES."*
| # | Flaw | Layer | Severity |
|---|------|-------|----------|
| Z1 | `_safe_enum` fix applied to `rust_backend.py` but NOT `real_zinc_plane.py` — other copy crashes | Bridge | **High** |
| Z2 | `_backup_20260530/` has `__init__.py` — accidental import loads old code | Repo | Medium |
| Z3 | `RealZincControlUnavailable` and `RealZincUnavailable` separate classes | Bridge | Low |
| Z4 | `test_account_reconcile_faults.py` requires Rust lib with no skip guard | Test | Low |
| Z5 | No health check endpoint — silent failures invisible to orchestration | Ops | **High** |
| Z6 | `process_intent()` calls `venue.submit()` without exception handler | Bridge | **High** |
| Z7 | `snapshot()` mixes Rust and Python accounting — capital values can diverge | Bridge | Medium |
| Z8 | `BingxVenueAdapter.close()` executor null-to-shutdown TOCTOU race | Venue | Medium |
| Z9 | Generated test f-string `chr(34)` template — SyntaxError risk on old Python | Test | Medium |
| Z10 | `launcher.py` uses Python 3.10+ `\|` union syntax — no min version documented | Config | Medium |
| Z11 | `_encode_packet`/`_decode_packet` duplicated in two files | Plane | Low |
| Z12 | Concurrent `process_intent()` on same slot — no lock, no queue | Bridge | Medium |
| Z13 | `test_alpha_blue_untouched_g7.py` hardcoded absolute path | Test | Low |
| Z14 | No exchange timestamp monotonicity check in WS stream | Venue | Low |
---
## H-Series: Edge Domains — Dependencies, Error Handling, Types, Contracts (Pass 5)
*Full detail in TRACE doc under "PASS 5 — EDGE DOMAINS."*