hjnormey/sentiment-engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dita_v2(bingx_venue): restore _publish_telemetry order_id/client_order_id kwargs + make post-ack telemetry non-fatal

Browse Source 
M1 re-vendor (89a1f1a) clobbered the T0-DEVIATION fix (20ad493): submit()/submit_async()
pass order_id=/client_order_id= post-ack, the signature dropped them. Every ENTER raised
TypeError AFTER the venue POST returned 200 OK -> rust_backend synthesised REJECTED ->
FSM rollback, while the venue kept the position. Flight-4: 8 bridged promotions, 6 orphan
SHORTs live on VST with a kernel that believes it is flat.

Two fixes:
1. signature accepts order_id/client_order_id again; snapshot prefers them (order is None
   on the submit path, so the ack row is the only id source).
2. post-ack telemetry wrapped: observability can never again veto an accepted order.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Codex
2026-07-13 05:08:12 +02:00
parent 459215b7d8
commit b46ebd2f82
1 changed files with 66 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
prod/clean_arch/dita_v2/bingx_venue.py
View File

@@ -298,6 +298,8 @@ class BingxVenueAdapter(VenueAdapter):
retry_after_ms: int = 0,
venue_order_status: str = "",
venue_event_kind: str = "",
order_id: str = "",
client_order_id: str = "",
details: dict[str, Any] | None = None,
) -> None:
plane = self._telemetry_plane
@@ -336,8 +338,10 @@ class BingxVenueAdapter(VenueAdapter):
asset=asset,
side=side,
action=action,
order_id=str(getattr(order, "venue_order_id", "") or ""),
client_order_id=str(getattr(order, "venue_client_id", "") or ""),
order_id=str(order_id or getattr(order, "venue_order_id", "") or ""),
client_order_id=str(
client_order_id or getattr(order, "venue_client_id", "") or ""
),
venue_order_status=venue_order_status,
venue_event_kind=venue_event_kind,
message=message,
@@ -620,6 +624,11 @@ class BingxVenueAdapter(VenueAdapter):
receipt = self._call_backend("submit_intent", legacy)
events = self._events_from_submit(submitted, receipt, None, None)
ack_row = dict(getattr(receipt, "raw_ack", {}) or {})
# Post-ack: the order is LIVE at the venue. Telemetry is observability,
# never a veto — an exception escaping here reaches the caller's submit
# guard, which synthesises a REJECTED event and rolls the FSM back while
# the venue keeps the position (orphan). Observability must not un-do fills.
try:
self._publish_telemetry(
phase="submit:done",
status=str(getattr(receipt, "status", "") or _row_text(ack_row, "status", default="NEW")),
@@ -637,6 +646,14 @@ class BingxVenueAdapter(VenueAdapter):
"asset": intent.asset,
},
)
except Exception as exc: # pragma: no cover - defensive, see comment above
import logging as _log
_log.getLogger(__name__).critical(
"FIX(bingx_venue): post-ack telemetry failed for intent=%s asset=%s — "
"order is LIVE at venue, events returned unchanged: %s",
intent.intent_id, intent.asset, exc,
)
return events
async def submit_async(self, intent: KernelIntent) -> List[VenueEvent]:
@@ -665,6 +682,11 @@ class BingxVenueAdapter(VenueAdapter):
receipt = await self.backend.submit_intent(legacy)
events = self._events_from_submit(submitted, receipt, None, None)
ack_row = dict(getattr(receipt, "raw_ack", {}) or {})
# Post-ack: the order is LIVE at the venue. Telemetry is observability,
# never a veto — an exception escaping here reaches the caller's submit
# guard, which synthesises a REJECTED event and rolls the FSM back while
# the venue keeps the position (orphan). Observability must not un-do fills.
try:
self._publish_telemetry(
phase="submit:done",
status=str(getattr(receipt, "status", "") or _row_text(ack_row, "status", default="NEW")),
@@ -682,6 +704,14 @@ class BingxVenueAdapter(VenueAdapter):
"asset": intent.asset,
},
)
except Exception as exc: # pragma: no cover - defensive, see comment above
import logging as _log
_log.getLogger(__name__).critical(
"FIX(bingx_venue): post-ack telemetry failed for intent=%s asset=%s — "
"order is LIVE at venue, events returned unchanged: %s",
intent.intent_id, intent.asset, exc,
)
return events
def _events_from_submit(self, intent: KernelIntent, receipt: Any, before, after) -> List[VenueEvent]: # noqa: ANN001